Skip to content

Replace `renderGFM(document.body)` for more specific selectors

Dannyel Cardoso da Fonseca requested to merge gitlab-community/gitlab:457180-dcf-replace-renderGFM-document-body-for-more-specific-selectors into master
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do and why?

This MR refactor the implementation of this MR Resolve "Mermaid diagrams and charts are not vi... (!133524 - merged) and remove its unit tests because they "[...] causes flaky test failures because importing everything inside the it can trigger compilation and test timeout." (Remove test 'settings/ci_cd/show/index_spec.js' (!150143 - merged))

The motivation to do so came up from this comment !149611 (comment 1867698961). The goal is replace renderGFM(document.body) for more specific selectors, avoiding document.body.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Sign In Page
Recording_2024-04-24_at_23.44.43
Sign Up Page
Recording_2024-04-24_at_23.48.33
Forgot Password Page
Recording_2024-04-24_at_23.47.21
Preview Sign In Page
Recording_2024-04-24_at_23.53.45
SAML single sign-on Page
Recording_2024-04-25_at_00.17.29

How to set up and validate locally

Run GDK locally and set the appearance of the sign-in pages:

  • [1] Admin > Settings > Appearance > Sign in/Sign up pages > Description
  • [2] Admin > Settings > Preferences > Sign-in and Help page > Additional text to show on the sign-in page
  • [3] Admin > Settings > General > Sign-in restriction > Sign-in text

Use the following content to fill the text fields:

```mermaid
graph TD;
  A-->B;
  A-->C;
  B-->D;
  C-->D;
```
Edited by Dannyel Cardoso da Fonseca

Merge request reports