Skip to content

Disable runner registration tokens for all groups on .com

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/413956/disable-runner-registration-tokens-on-groups into master

🚨 🚨 NOTE: This MR should only be merged on May 6th-7th, in time for the 3rd breaking changes window (2024-05-06 09:00 UTC to 2024-05-08 22:00 UTC) 🚨 🚨

What does this MR do and why?

This MR disables runner registration tokens for all groups on .com. The idea is to force customers who still rely on runner registration tokens to take an explicit step to re-enable them, if they cannot yet migrate to the new runner creation workflow. Runner registration tokens will be removed in %18.0.

The idea behind the changes in this MR:

  • Schedule a batched background migration that is a no-op for self-managed instances (it is also EE-only).
  • Change tests that were dependent on allow_runner_registration_token being true. This is done by setting the appropriate value in namespace_setting. For simplicity, whenever we need to test with a different value, we make the change at the instance level, since the setting is hierarchical in nature.

Changelog: changed

Closes #413956 (closed)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

n/a

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

n/a

Database query plan

Disable setting on top-level groups 
UPDATE "namespace_settings" SET "allow_runner_registration_token" = FALSE
WHERE "namespace_settings"."namespace_id" IN (
  SELECT "namespaces"."id"
  FROM "namespaces"
  WHERE "namespaces"."type" = 'Group' AND "namespaces"."parent_id" IS NULL)
Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports