Skip to content

Remove Banzai escape filters and use native support

Brett Walker requested to merge 456892-remove-banzai-escape-filters-and-use-native-support into master

What does this MR do and why?

Escape filtering for handling escapes specifically for our references (such as \@ to not mention a user) is mostly handled by the rust parser. So we can remove most of the processing.

We still need to strip out any <span data-escaped-char> that is not one of our references, because our reference parsing does not know how to handle a <span data-escaped-char> in the middle of the reference text. For example, @j\_lar still has to parse correctly. See Label parsing should handle embedded escaped chars (#457556)

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  • go into a project and create a label called under_scored_

  • in an issue comment, enter the following markdown

    ~under_scored\_ : this should find the correct label

\~under_scored\_ : this keep the label from being recognized

  • the first one should be a recognized label, the second one was short-circuited and did not recognize it as a label

  • you can also try some of the examples in #415624 (closed). This MR fixes those cases.

Related to #456892 (closed)

Edited by Brett Walker

Merge request reports