Skip to content

Do not run full rubocop in predictive pipelines

David Dieulivol requested to merge ddieulivol-rubocop_in_predictive_pipelines into master

From Draft to Ready

Context

Closes gitlab-org/quality/engineering-productivity/team#472 (closed)

What does this MR do and why?

Never run a full rubocop in predictive pipelines, even when changing files that would match the .rubocop-patterns pattern.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Proof of work

I added a test commit to change the .rubocop_todo/fips/sha1.yml, which would match the .rubocop-patterns pattern:

Rubocop job output:

$ fail_on_warnings bundle exec rubocop --parallel --force-exclusion .gitlab/ci/rules.gitlab-ci.yml .rubocop_todo/fips/sha1.yml
Inspecting 0 files
0 files inspected, no offenses detected
Edited by David Dieulivol

Merge request reports