Exclude requested access users
What does this MR do and why?
When a user requests access to a group/project, a Member
record is created with a developer access level and a requested_at
timestamp.
This user does not gain access until approved, at which point the requested_at
timestamp is cleared.
As discussed in https://gitlab.com/gitlab-org/gitlab/-/issues/456695, we need to filter out members who only have requested access to a groups/projects.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- In your local GDK, ensure you have an Ultimate license
- Sign up as a new user
- As the new user, request access to a group
- In a rail console, check billable users:
User.billable.include?(User.last)
- Confirm the result is
false
- Performing the same query on
master
should (incorrectly) returntrue
, confirming this branch fixes the problem
Edited by Vijay Hawoldar