Skip to content

Updated requesting changes blocking behaviour

Phil Hughes requested to merge ph/changesRequestedBlocking into master

What does this MR do and why?

With this change we create a new record against merge requests that signal that a reviewer has requested changes. This change means the merge request goes into a blocked state until that user approves the merge request. Before this change you could override this request by simply removing the user as a reviewer.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

How to set up and validate locally

  • Enable the mr_reviewer_requests_changes feature flag
  • Visit a merge request
  • Assign yourself as a reviewer
  • Create a new review requesting changes
  • Merge request widget should say merge request is blocked

Merge request reports