Skip to content

Remove referrer from Version Check

Niko Belokolodov requested to merge 438558-remove-referer-from-version-check into master

What does this MR do and why?

With https://gitlab.com/gitlab-org/gitlab-services/version.gitlab.com/-/issues/37 done we're no longer saving any data coming from version check.

This MR removes referrer which is currently being sent superfluous and a potential point of unneeded privacy concerns

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Perform version check in rails c (it calls the production Version app):

[1] pry(main)> VersionCheck.new.calculate_reactive_cache
=> {"latest_stable_versions"=>[], "latest_stable_version_of_minor"=>nil, "latest_version"=>"16.11.0", "severity"=>"success", "critical_vulnerability"=>false, "details"=>""}

Related to #438558 (closed)

Edited by Niko Belokolodov

Merge request reports