Draft: Remove min and max_concurrency option in Sidekiq cluster (2nd attempt)
What does this MR do and why?
This is the 2nd attempt to remove the min-concurrency and max-concurrency options. It was reverted in !149888 (merged) due to failed E2E tests because the tests are running with Omnibus.
e2e:package-and-test child pipeline succeed after the removal of configuration in Omnibus omnibus-gitlab!7549 gets merged.
1st attempt: !149690 (merged)
To remove the deprecated min_concurrency and max_concurrency options for sidekiq cluster CLI. This is mainly affecting self-managed instances.
We don't use the min-concurrency and max-concurrency options for GitLab.com. For GitLab.com we specify the concurrency here in k8s-workloads, which will then be passed as environment variable in the helm charts template, before finally passed as -c (or --concurrency) in CNG.
Deprecation announcement https://docs.gitlab.com/ee/update/deprecations.html#min-concurrency-and-max-concurrency-in-sidekiq-options
Part of gitlab-com/gl-infra/scalability#3422
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.