Skip to content

Update specs to new factories syntax part 9

Pavel Shutsin requested to merge update-user-factories-usages-part-9 into master

What does this MR and why?

This MR updates part of our factories to new syntax introduced in !149259 (merged) and !149107 (merged)

E.g.

# before
let_it_be(:project) { create(:project) }
let_it_be(:user) { create(:user) }

before_all do
  project.add_developer(user)
end

# after
let_it_be(:project) { create(:project) }
let_it_be(:user) { create(:user, developer_of: project) }
# or
let_it_be(:user) { create(:user) }
let_it_be(:project) { create(:project, developers: user) }

See #455818 (closed) for full list of MRs

See $3698657 for parser source code.

It's pure specs refactoring, no user facing changes.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports