Skip to content

Use RemoteMirrors::DestroyService for push mirror deletion

Vasilii Iakliushin requested to merge 455518_add_remote_mirror_delete_service into master

What does this MR do and why?

Contributes to #455518 (closed)

Problem

Currently, push mirror deletion logic is included in Projects::UpdateService. It's error-prone and inconvenient to use push mirrors.

Solution

Add a RemoteMirrors::DestroyService to handle push mirror deletion.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Enable feature flag use_remote_mirror_destroy_service
  2. Visit Settings -> Repository -> Mirroring repositories
  3. Try to create a Push mirror
  4. Try to delete a new Push mirror
  5. Both actions should work without any problems
Edited by Vasilii Iakliushin

Merge request reports