Skip to content

Remove redundant button styling classes

Mark Florian requested to merge 417852-remove-unneeded-button-classes into master

What does this MR do and why?

Remove redundant button styling classes

It seems the button gets all the styles it needs from the dropdown-menu ancestor.

This is a quick fix to remove a false positive finding in the Pajamas Adoption Scanner. A more correct migration would rewrite the dropdown in Vue.

Addresses #417852 (closed).

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
promote_button_regular_before promote_button_regular_after
promote_button_hover_before promote_button_hover_after
promote_button_active_before promote_button_active_after

How to set up and validate locally

  1. Visit a project milestone page in a project with a parent group (e.g., possibly http://gdk.test:3000/gitlab-org/gitlab-shell/-/milestones/9 is already seeded).
    • You might need to create one: go to any project which is in a group (not user namespace), click Plan -> Milestones -> New Milestone, fill out the form, submit, and go back to step 1.
  2. Click the ︙ button in the top right.
  3. View/interact with the Promote option.

Related to #417852 (closed)

Edited by Mark Florian

Merge request reports