Skip to content

Add create service for push mirrors

Vasilii Iakliushin requested to merge 455515_create_remote_mirror_creation_service into master

What does this MR do and why?

Contributes to #455515 (closed)

Problem

Currently, push mirror creation logic is duplicated and inconsitent between API and UI. Moreover, we rely on Projects::UpdateService to make changes to push mirrors. It's error-prone and inconvenient to use push mirrors.

Solution

  • Extract common push mirror creation logic into RemoteMirrors::CreateService
  • Add a new value object Attributes to handle allowed attributes list

Roadmap

  1. Add create service for push mirrors (!149700 - merged) 👈
  2. Use RemoteMirrors::CreateService in push mirror... (!149263 - merged) (uses a new service)
Edited by Vasilii Iakliushin

Merge request reports