Skip to content

Cleanup approval_rules_drawer feature flag

Jacques Erasmus requested to merge 455803-remove-approval-rules-drawer-ff into master

What does this MR do and why?

Removes all references of the approval_rules_drawer feature flag + updates the docs.

Tasks

  • Update docs
  • Remove FF references
  • Remove the Create modal
  • Remove the Vuex actions related to the Create modal
  • Test on Settings, Branch rules and MR New/Edit pages

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

No visual changes are expected as the feature flag is already enabled by default.

How to set up and validate locally

A drawer instead of a modal should be used anywhere we can add/edit Merge request approval rules.

Branch rules

  1. Add a Branch rule
    • Navigate to Project > Repository > Settings > Branch rules > Add branch rule
  2. View the branch rule created in step 1
    • Navigate to Project > Repository > Settings > Branch rules > View details
  3. On the Branch rule details screen the Approval rules app should display and work as expected
  4. Edit/Add should should a drawer containing the approval rule form

Settings > Merge request approvals

  1. Navigate to Project > Settings > Merge requests > Merge request approvals
  2. Adding, editing, deleting approval rules should work as expected

Merge request Add/Edit

  1. Navigate to Merge request > New or Merge request > Edit
  2. Adding, editing, deleting approval rules should work as expected

Related to #455803 (closed)

Edited by Jacques Erasmus

Merge request reports