Removal of more backend Visual Review code
What does this MR do and why?
This removes a bunch of dead code that's no longer used as of Remove visual review tools (!149586 - merged)
There was more removal than I thought, so we removed interfaces and anything user-facing in the first MR, and are sending follow-ups to do more removal behind the scenes.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
Just run the test suite. All the changes in here are removals, so there's no additive thing to go look at. If everything else still works, we're good.
Related to #387751 (closed)
Merge request reports
Activity
changed milestone to %17.0
added Category:Review Apps GitLab Premium TW-DRILysanne VerifyP3 backend backend-weight1 breaking change cicdactive deprecation devopsverify documentation frontend frontend-weight1 grouppipeline execution maintenanceremoval release post item release post itemremoval sectionci typemaintenance workflowready for development labels
assigned to @drew
- Resolved by drew stachon
cc @pburdette Just to give you a heads up that I'm getting somewhat aggressive with the removals in here, so we'll see how it goes. We can merge this into your branch eventually, and have the one MR queued up for a cleaner removal.
- A deleted user
3 Warnings ⚠ For the following files, a review from the Data team and Analytics Instrumentation team is recommended
Please check the analytics instrumentation Service Ping guide or the Snowplow guide.For MR review guidelines, see the Internal Analytics review guidelines.
app/services/notes/create_service.rb
config/events/202109151015_notes__create_service_execute.yml
⚠ eb737e9b: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
2 Messages 📖 CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelog
trailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
📖 This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/ci/variables/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer analytics instrumentation @bastirehm
(UTC+2, 2 hours ahead of author)
Maintainer review is optional for analytics instrumentation backend @zmartins
(UTC+2, 2 hours ahead of author)
@kerrizor
(UTC-7, 7 hours behind author)
frontend @mcavoj
(UTC+2, 2 hours ahead of author)
@djadmin
(UTC+5.5, 5.5 hours ahead of author)
~"Backend Static Code Analysis" Reviewer review is optional for ~"Backend Static Code Analysis" @dstull
(UTC-4, 4 hours behind author)
groupauthorization Reviewer review is optional for groupauthorization @alexbuijs
(UTC+2, 2 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger- Resolved by drew stachon
- Resolved by drew stachon
mentioned in merge request !150175 (merged)
removed milestone %17.0
Removing the milestone and marking this as a Draft, to be superseded by a smaller backend removal for %17.0: Remove all interfaces to Visual Review feature (!150175 - merged)
frontend removal in Remove visual review tools (!149586 - merged)
We can continue this effort as a dead-code cleanup after those official removal MRs ship in %17.0.
Making myself a note to remote this layout file in this MR
added pipeline:run-as-if-jh label