Force package-and-test to run when Redis changes
What does this MR do and why?
Force package-and-test to run when Redis changes
- When specific changes to Redis are performed, we should ensure the package and test job runs and is successful
- We've been hindered in the past when changes to these paths change how Redis leverages our test infrastructure, thus we need to ensure that we can legitimately build and test changes that target when and how Redis is used
- The goal here is to capture failures during builds and or tests where changes to how Redis connections are modified
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Reference past incident where changes to the initilization of Redis caused problems during build time blocking AutoDeploy. gitlab-com/gl-infra/production#17659 (closed)
How to set up and validate locally
Tracing:
- The job that we are looking to make required: https://gitlab.com/gitlab-org/gitlab/-/blob/12ddd06ee0b794e5fd58c7675c247765e9a0093b/.gitlab/ci/qa.gitlab-ci.yml#L68 - sucks in
.qa:rules:package-and-test-ee - Which is defined here: https://gitlab.com/gitlab-org/gitlab/-/blob/6d36b4a4b46ef14d570279bc795863e40e15c43c/.gitlab/ci/rules.gitlab-ci.yml#L1689 - sucks in
.qa:rules:package-and-test-common - Which is defined here: https://gitlab.com/gitlab-org/gitlab/-/blob/6d36b4a4b46ef14d570279bc795863e40e15c43c/.gitlab/ci/rules.gitlab-ci.yml#L1575 - sucks in
*code-patterns - Which is what we are changing: https://gitlab.com/gitlab-org/gitlab/-/blob/jts/force-redis-package-and-test/.gitlab/ci/rules.gitlab-ci.yml#L422
Edited by John Skarbek