Skip to content

Remove feature-flag restrict_member_roles

Hinam Mehra requested to merge 444971-remove-ff-restrict-member-roles into master

What does this MR do and why?

  • Remove feature flag restrict_member_roles, but keep the enabled functionality.
  • When on SaaS, users can create group-level custom roles but not instance-level custom roles.
  • When on self-managed, users can create instance-level custom roles but not group-level custom roles.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

  1. Enable SaaS mode with
export GITLAB_SIMULATE_SAAS=1
gdk restart
  1. Sign-in as admin and navigate to any group that you are an owner, then go to Settings > Roles and Permissions
  2. You should be able to create a custom role but navigating to /admin/application_settings/roles_and_permissions should result in a 404.
  3. Disable SaaS mode
export GITLAB_SIMULATE_SAAS=0
gdk restart
  1. and repeat steps 2 and 3. However, now you should be able to create an instance-level custom role but not a group-level one.

Related to #444971 (closed)

Edited by Hinam Mehra

Merge request reports