Skip to content

Fix LFS token check & add test for specific case

Kevin-Damian Gosa requested to merge gitlab-community/gitlab:443796_fix_500_when_no_login_is_specified into master
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do and why?

This MR fixes the 500 error when fully invalid basic credentials are supplied and also adds a test for this case.

Fixes #443796

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Execute curl -H "Authorization: Basic <instance>/flightjs/Flight.git/info/refs?service=git-upload-pack --output file
  2. Validate that no 500 error is responded and an invalid credentials response is returned.
Edited by 🤖 GitLab Bot 🤖

Merge request reports