Expose trigger short token to CI
-
Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA
What does this MR do and why?
This MR adds the CI_TRIGGER_SHORT_TOKEN
variable to the CI as requested in #429449 (closed). This is needed to be able to check if a pipeline was triggered via a trigger token and to check which trigger token was used in a pipeline.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Setup a runner for the dev instance
- Create a pipeline in a project. Example:
stages:
- test
test-job:
stage: test
script:
- echo "$CI_JOB_NAME"
- echo "$CI_TRIGGER_SHORT_TOKEN"
- Create a trigger token by navigating to
Settings -> CI/CD -> Pipeline trigger tokens
- Create a pipeline by sending a POST request to
https://<instance url>/api/v4/projects/<project_id>/ref/<ref_name>/trigger/pipeline?token=<token>
- Verify that
CI_TRIGGER_SHORT_TOKEN
has a value in the job output
Merge request reports
Activity
Hey @kevin.gosa!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
assigned to @kevin.gosa
1 Warning There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/ci/variables/predefined_variables.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @ahegyi
(UTC+2)
@suraj_tripathy
(UTC+5.5)
~"Verify" Reviewer review is optional for ~"Verify" @grzesiek
(UTC+2)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
added linked-issue label
added devopsverify sectionci labels
added documentation featureaddition labels
mentioned in issue #429449 (closed)
- Resolved by Aleksei Lipniagov
@gitlab-bot ready @ahegyi
added workflowready for review label and removed workflowin dev label
requested review from @ahegyi
Hi
@marcel.amirault
! Please review this documentation merge request. This message was generated automatically. You're welcome to improve it.added twtriaged label
requested review from @marcel.amirault
@marcel.amirault
@ahegyi
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
- Resolved by Kevin-Damian Gosa
changed milestone to %17.0
requested review from @shampton and removed review request for @marcel.amirault and @ahegyi
added Technical Writing docsfeature labels
requested review from @dbiryukov and removed review request for @shampton
added pipeline:mr-approved label
- Resolved by Aleksei Lipniagov
@marcel.amirault
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
- Resolved by Hordur Freyr Yngvason
@kevin.gosa Great job! Your contribution to the community is highly appreciated!
LGTM
@alipniagov Could you please perform a backend maintainer review part?
requested review from @alipniagov and removed review request for @dbiryukov
1 Warning There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/ci/variables/predefined_variables.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Category Reviewer Maintainer backend @mokhax
(UTC-6)
@suraj_tripathy
(UTC+5.5)
~"Verify" Reviewer review is optional for ~"Verify" @hfyngvason
(UTC-4)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
requested review from @hfyngvason and removed review request for @alipniagov
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for a8bc3a3aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 83 | 0 | 9 | 0 | 92 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 304 | 0 | 19 | 0 | 323 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for a8bc3a3aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Verify | 150 | 0 | 30 | 0 | 180 | ✅ | | Create | 152 | 0 | 21 | 2 | 173 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 328 | 0 | 53 | 2 | 381 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @greg
mentioned in merge request !149335 (closed)
enabled an automatic merge when the pipeline for a8bc3a3a succeeds
@hfyngvason, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
@kevin.gosa, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 42f4224b
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label