Skip to content

Draft: fix issue 455711: pass the event_name into the `additional_details` hash

Thor Kell requested to merge thor.kell/gitlab:thor.kell-master-patch-51715 into master
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do and why?

This is a simple (and perhaps foolish) fix for #455711: we just add event_name to the additional_details hash, which should persist it into the HTTP API.

It has the downside of not persisting the change as part of the Audit Event table ... but this also means that a full migration of the Audit Event table might not be needed. There's also this epic which suggests that putting more fields into additional_details is not a great plan.

This may require updating the Go library and other libs that require types for additional_details.

If GitLab folks are happy with this approach, I can dig into updating tests and find what libraries need to be updated!

Edited by Thor Kell

Merge request reports