Skip to content

Migrate admin labels actions dropdown to vue component

Taras Tadai requested to merge 454688-migrate-dropdown-in-labels into master

What does this MR do and why?

Migrate bootstrap dropdown in app/views/admin/labels/_label.html.haml to pajamas component.

  • Replaced bootstrap actions dropdown with compatible vue component
  • Replaced affected confirmation dialog with compatible vue modal
  • Modified delete label modal to be event based so that it can be used by both vue & non-vue UI

It's a part of Pajamas adoption project

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
label_actions_old label_actions_new
label_actions_old2 label_actions_new2

How to set up and validate locally

Case1

  1. Goto Admin Area -> Labels
  2. Verify label actions dropdown.
  3. Edit some label.
  4. Verify Delete button in the edit form.

Case2

  1. Open some project
  2. Goto Manage -> Labels
  3. Verify delete action in the actions dropdown.
  4. Edit any label and verify the Delete button in the edit form.

Also covered by spec/features/admin/admin_labels_spec.rb

Related to #454688 (closed)

Edited by Taras Tadai

Merge request reports