Protected packages + containers: Use shared example in service tests
requested to merge gitlab-community/gitlab:427547-gerardo-navarro-protected-containers-graphql-follow-up-use-shared-example-in-tests into master
-
Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA
What does this MR do and why?
This MR intends to apply the DRY principle by reusing the existing shared examples for service response objects, see https://gitlab.com/gitlab-community/gitlab/-/blob/fdf61409f4e8ad44118cd82e987ad76045ef37a6/spec/support/shared_examples/services/service_response_shared_examples.rb.
Additionally, this MR resolved some rubocop-related todos.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
Only backend changes.
How to set up and validate locally
- Execute the tests
Edited by Gerardo Navarro