Increase test code quality for package controller
requested to merge gitlab-community/gitlab:437928-gerardo-navarro-refactor-test-packages-controller-spec into master
-
Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA
What does this MR do and why?
- Applying the use of
subjectas best practice pattern in test file, see https://www.betterspecs.org/#subject - Increase clarity, consistency and DRY principle
Changelog: other
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
MR Checklist (@gerardo-navarro)
-
Changelog entry added, if necessary -
Documentation created/updated via this MR -
Documentation reviewed by technical writer or follow-up review issue created -
Tests added for this feature/bug -
Tested in all supported browsers -
Conforms to the code review guidelines -
Conforms to the merge request performance guidelines -
Conforms to the style guides -
Conforms to the javascript style guides -
Conforms to the database guides
Screenshots or screen recordings
Just changes in the test backend
How to set up and validate locally
- Execute the relevant test
bundle exec rspec spec/requests/projects/packages/packages_controller_spec.rbEdited by Gerardo Navarro