Skip to content

E2E test: handle approval rule draw in tests

Jay McCure requested to merge jmc-423899 into master

What does this MR do and why?

Resolves #423899 (comment 1856311429)

A new mechanism to add approval rules to MR is being rolled out. The FF is turned on in staging, hence the above failure.

This MR handles both mechanisms to add approval rules to MRs. Once the approval rule draw is default and the FF is removed, we can remove the old way of adding approval rules.

How to set up and validate locally

Feature.disable :approval_rules_drawer
QA_GITLAB_URL=https://gdk.test:3443  GITLAB_QA_PASSWORD_1=x GITLAB_QA_PASSWORD_2=x bundle exec rspec qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb
Feature.enable :approval_rules_drawer
QA_GITLAB_URL=https://gdk.test:3443  GITLAB_QA_PASSWORD_1=x GITLAB_QA_PASSWORD_2=x bundle exec rspec qa/specs/features/ee/browser_ui/3_create/merge_request/approval_rules_spec.rb
Edited by Jay McCure

Merge request reports