Skip to content

Refactor spec helper stub_session

Drew Blessing requested to merge dblessing_change_session_helper_sig into master

What does this MR do and why?

In !148548 (merged), the stub_session spec helper was updated to allow a new user_id param. To avoid lots of unnecessary updates in that MR, we left a less than ideal method signature. This is a follow-up refactor to reduce ambiguity and update all usage to ensure session data is passed as a hash via a keyword arg.

!148548 (merged) must be merged prior to this MR.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Edited by Drew Blessing

Merge request reports