Skip to content

Fix rich text editor suggestions user alignment when using tailwind

Dan MH requested to merge fix-rte-suggestions-dropdown into master

What does this MR do and why?

Fix alignment issues in the rich text editor suggestions dropdown.

In the old utils gl-flex did not exist. In the tailwind generated one’s it does

So before gl-flex was useless and had no effect and now it does, canceling the effect of vertical-align: middle.

Also updated the spacing to match non-rich text editor

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-04-10_at_12.46.32 Screenshot_2024-04-10_at_12.45.17

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Note: Please revert the changes below after a review, otherwise you might run into CSS issues on other branches

  1. In rails console (or via toogle: http://127.0.0.1:3000/rails/features)
    Feature.enable(:tailwind_all_the_way)
  2. In your GDK, add: export TAILWIND_ALL_THE_WAY=true to env.runit
  3. In /gitlab/ run yarn run tailwindcss:build
  4. Restart webpack / vite: gdk restart webpack / gdk restart vite
  5. Visit any page. The page should look visually alright and a CSS file named assets/tailwind_all_the_way-[hash].css should be loaded
Edited by Dan MH

Merge request reports