Skip to content

Housekeeper: Improve message on completion

Manoj M J requested to merge mmj-housekeeper-wording-improvement into master

What does this MR do and why?

This MR improves the messaging to developer after a keep is run. Currently:

  • it does not differentiate between a dry run and an actual run, causing confusion. This has been fixed.
  • No pluralization for MR count, this has been improved.

Before:

Dry run Actual run
Screenshot_2024-04-10_at_11.41.55_AM Screenshot_2024-04-10_at_11.41.55_AM

Yup, same message for both kind of runs, confusing.

After:

Dry run (singular) Dry run (plural)
Screenshot_2024-04-10_at_11.41.13_AM Screenshot_2024-04-10_at_11.43.35_AM
Actual run (singular) Actual run (plural)
Screenshot_2024-04-10_at_11.41.55_AM Screenshot_2024-04-10_at_11.42.57_AM

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Merge request reports