Skip to content

Add feature specs for the NPM dependency proxy

David Fernandez requested to merge 435644-feature-specs into master

🔭 Context

In NPM dependency proxy tgz download file endpoint (!144320 - merged), we added the download endpoint in the NPM dependency proxy.

See !144320 (merged) for way more details.

At that point, that MR grew into an unreasonable size and we decided to split it in two. One part that was extracted was features specs.

This MR adds those features specs to the NPM dependency proxy.

This is part of issue NPM dependency proxy: implement the download tg... (#435644 - closed) which adds the download endpoint to the NPM dependency proxy.

🤔 What does this MR do and why?

  • Add features specs for the NPM dependency proxy.
    • We are following the same structure as the features specs for the Maven dependency proxy.
    • Common contexts are centralized to avoid code duplication.

✅ MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

👌

🌈 Screenshots or screen recordings

Feature specs ... so uh... 🤷 ... no UI changes 😸

☂ How to set up and validate locally

Run the feature specs that have been added here:

$ bundle exec rspec ee/spec/features/dependency_proxy/packages/npm_spec.rb

[ snip ... snip ]

Finished in 12.67 seconds (files took 13.7 seconds to load)
8 examples, 0 failures
Edited by David Fernandez

Merge request reports