Skip to content

Enable approval rules drawer feature flag by default + update docs

Jacques Erasmus requested to merge 444628-enable-approval-rules-drawer-ff into master

What does this MR do and why?

Enables the approval_rules_drawer feature flag by default, and adds a note to the docs about the change.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Before After
Screenshot_2024-03-14_at_09.53.42 Screenshot_2024-03-14_at_09.54.16

Screen_Recording_2024-03-14_at_09.56.27.2024-03-14_09_57_41

How to set up and validate locally

Branch rules

  1. Add a Branch rule
    • Navigate to Project > Repository > Settings > Branch rules > Add branch rule
  2. View the branch rule created in step 1
    • Navigate to Project > Repository > Settings > Branch rules > View details
  3. On the Branch rule details screen the Approval rules app should display and work as expected
  4. Edit/Add should should a drawer containing the approval rule form

Settings > Merge request approvals

  1. Navigate to Project > Settings > Merge requests > Merge request approvals
  2. Adding, editing, deleting approval rules should work as expected

Merge request Add/Edit

  1. Navigate to Merge request > New or Merge request > Edit
  2. Adding, editing, deleting approval rules should work as expected

Related to #444628 (closed)

Edited by Jacques Erasmus

Merge request reports