Skip to content

Allow approvals_required to be lower than project

Patrick Bajao requested to merge 12607-allow-lower-approvals-required into master

What does this MR do?

MR level approvals_required are currently restricted to be higher than project level approvals_required.

This removes that restriction so the logic will be simpler.

Documentation changes can be found in this CE MR: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31268.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

#12607 (closed)

Edited by Patrick Bajao

Merge request reports