MR approval in MR list: Fix display of total approvals
What does this MR do and why?
MR approval in MR list: Fix display of total approvals
Reported by a user in !148364 (comment 1852378963)
Reverting !148364 (merged) will actually not fix the problem as it will display the wrong amount as well: If no approvals are given, it still shows 1 approval given.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
| Unapproved (0 approvals) | Approved |
|---|---|
| This MR (with display approval amounts fixed) | |
| Multiple rules (Expected 0/3) | Expected (2/3) |
 |
 |
| Single rule (Expected 0/2) | Expected 1/2 |
 |
 |
| !148364 (merged) | |
| Multiple rules (Expected 0/3) | Expected (2/3) |
 |
 |
| Single rule (Expected 0/2) | Expected 1/2 |
 |
 |
| Before !148364 (merged) | |
| Multiple rules (Expected 0/3) | Expected (2/3) |
 |
 |
| Single rule (Expected 0/2) | Expected 1/2 |
 |
 |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Edited by Sascha Eggenberger