Show status, milestone and statistics on service desk issue list
What does this MR do and why?
Adds milestone, status and statistic information (like upvotes and MR counts) to service desk issues shown in the service desk list. This brings issues in this list inline with issues that show in a normal issues list.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
These screenshots show the same issue with identical data:
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Check out this branch locally
- Ensure that service desk it turned on in your GDK
- Create a service desk ticket
- upvote the service desk ticket
- create an MR for the service desk ticket
- assign the ticket to a milestone
- add a health status to the service desk ticket
- View the list of service desk issues (
http://gdk.test:3000/$GROUP/$PROJECT/-/issues/service_desk/
). Information about milestone, health status, MRs, and upvotes will show on the list.
Related to #454838 (closed), #425467 (closed)
Merge request reports
Activity
changed milestone to %16.11
assigned to @clavimoniere
- Resolved by David Pisek
@nickleonard can you do a UX review here?
@msaleiko can you review for grouprespond?
requested review from @nickleonard and @msaleiko
- A deleted user
added frontend label
- Resolved by Chad Lavimoniere
1 Warning ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message 📖 This merge request includes changes to Vue files that have both CE and EE versions. Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/issues/service_desk/components/service_desk_list_app.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
Reviewer roulette
Category Reviewer Maintainer frontend @rcrespo3
(UTC-4, same timezone as author)
@dmishunov
(UTC+2, 6 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 2c1668d2 and 135ed3c1
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.32 MB 4.32 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 % 😨 Significant Growth: 1Expand
Entrypoint / Name Size before Size after Diff Diff in percent pages.projects.issues.service_desk 991.57 KB 1 MB +36.66 KB 3.7 %
Your MR has at least one entrypoint growing significantly (more > 1 KB or 2%). If you write new or extend existing features, this is expected and there is nothing to worry about.
Please consider pinging someone from the FE Foundations (
@leipert
,@markrian
,@pgascouvaillancourt
,@sdejonge
or@thutterer
) for review, if you are unsure about the size increase.Note: We do not have exact data for 2c1668d2. So we have used data from: ec0811c7.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 Dangeradded 1 commit
- 0375b639 - Show status, milestone and statistics on service desk issue list
requested review from @psjakubowska
added pipeline:mr-approved label
- Resolved by Chad Lavimoniere
👋 @msaleiko
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
✅ test report for 135ed3c1expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 77 | 0 | 9 | 0 | 86 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 0 | 19 | 0 | 317 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
✅ test report for 135ed3c1expand test summary
+---------------------------------------------------------------------+ | suites summary | +----------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +----------------+--------+--------+---------+-------+-------+--------+ | Monitor | 36 | 0 | 13 | 0 | 49 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Create | 152 | 0 | 21 | 2 | 173 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +----------------+--------+--------+---------+-------+-------+--------+ | Total | 208 | 0 | 37 | 2 | 245 | ✅ | +----------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 135ed3c1 - Show status, milestone and statistics on service desk issue list
mentioned in merge request !148364 (merged)
requested review from @dpisek and removed review request for @psjakubowska
enabled an automatic merge when the pipeline for 57a2b38e succeeds
🛠 Generated bygitlab_quality-test_tooling
.
🐌 Slow tests detected in this merge request. These slow tests might be related to this merge request's changes.Click to expand
Job File Name Duration Expected duration #6595895761 spec/features/issues/service_desk_spec.rb#L29
Service Desk Issue Tracker navigation to service desk can navigate to the service desk from link in the sidebar 63.54 s < 50.13 s - A deleted user
added rspec:slow test detected label
mentioned in commit 9249b1d7
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2945 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label