Skip license capacity check for security policy bot user
What does this MR do and why?
This MR fixes a problem identified in GitLab Security Policy Bot can be blocked as a ... (#439129 - closed) where we required additional approval for creation of Security Policy Bot user in certain cases. This MR resolves that issue.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
How to set up and validate locally
From #439129 (closed):
- Create a GDK instance.
- Setup the GDK instance to simulate GitLab.com with:
export GITLAB_SIMULATE_SAAS=1
in theenv.runit
file, and follow the steps to allow use of licensed EE features to be available to groups. - Once the instance is operational, enable FF with:
Feature.enable(:saas_user_caps)
via GDK rails console. (This is enabled on GitLab.com). - Create a new top-level group, and set a user-cap of
1
. This will limit the max users to just the existing user that created the group. - Within the Admin Area, set the new group to 'Ultimate'.
- Within the top-level group, create a new scan execution policy that attempts to run on a schedule, such as for Dependency Scanning every 15 minutes.
- Create a project beneath the top-level group.
- Go to the top-level group's Usage Quotas > Pending Members page (for example:
http://localhost:3000/groups/<top-level-group>/-/usage_quotas/pending_members
) and confirm that there are no pending users in the members list.
Related to #439129 (closed)
Merge request reports
Activity
changed milestone to %16.11
assigned to @alan
- Resolved by Siddharth Dungarwal
- Resolved by Siddharth Dungarwal
@mcavoj, would you mind taking a first look?
requested review from @mcavoj
Reviewer roulette
Category Reviewer Maintainer backend @bhrai
(UTC+2, same timezone as author)
@cablett
(UTC+12, 10 hours ahead of author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @sdungarwal and removed review request for @mcavoj
added pipeline:mr-approved label
- Resolved by Siddharth Dungarwal
@mcavoj
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 33345f3cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Create | 77 | 0 | 9 | 0 | 86 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 0 | 19 | 0 | 317 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 33345f3cexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 272 | 0 | 19 | 1 | 291 | ✅ | | Create | 152 | 0 | 21 | 2 | 173 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 444 | 0 | 42 | 3 | 486 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
enabled an automatic merge when the pipeline for 316959c1 succeeds
mentioned in commit a3aabce1
mentioned in incident gitlab-org/quality/engineering-productivity/master-broken-incidents#5841 (closed)
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in incident gitlab-com/gl-infra/production#17820 (closed)
mentioned in commit 3103eba3
mentioned in merge request !149274 (merged)
mentioned in merge request !149276 (merged)
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2945 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label