Skip to content

Dont run component spec in relative-url

What does this MR do and why?

Sorry for addressing multiple issues in 1 MR, but they are relatively small changes so Im not seeing any harm here 😬

  • Fix https://gitlab.com/gitlab-org/gitlab/-/issues/454630 - I forgot about relative url scenario. Trying to get the domain name differently by explicitly removing the scheme from the address, that should returns the path with relative url.
  • Also fix https://gitlab.com/gitlab-org/gitlab/-/issues/454793 - not running ascending sorting check in dotcoms since there are too many components across the instance for various reasons that would require pagination. This spec is still planned to be shifted left in the future so I dont think we need to add another layer of complication.
  • Also address a follow up request #452109 (closed) - to move enabling CI component project setting to a flow. Having it in this same MR since it's a very small change.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Run locally against GDK or dotcoms env.

  1. In qa/ dir, bundle install
  2. Start GDK if run agaisnt GDK
  3. Run command
QA_GITLAB_URL=http://<local.ip.address>:3000 bundle exec rspec qa/specs/features/browser_ui/4_verify/ci_components_catalog/ci_catalog_sorting_spec.rb
QA_GITLAB_URL=http://<local.ip.address>:3000 bundle exec rspec qa/specs/features/browser_ui/4_verify/ci_components_catalog/run_component_in_project_pipeline_spec.rb

Related to #454630

Edited by Tiffany Rea

Merge request reports