Skip to content

Add pagination for the approval rules in the `Merge requests` settings

Anton Kalmykov requested to merge gitlab-community/gitlab:378865-Merge-request-approval-rule-list-is-limited-to-20-in-the-UI into master

What does this MR do and why?

Add pagination for the approval rules in the Merge requests settings

  • Remove the limit to display the first 20 approval rules in the Merge request approval section on the Merge request project settings page
  • Add Show more button so the user will be able to review all the approval rules
  • Update add/update/delete rules logic so that the user can instantly see the result
  • Update spec files

Closes: #378865 (closed)

Changelog: changed

EE: true

Screenshots or screen recordings

Before After
before.mov after-2.mp4

How to set up and validate locally

  1. Run GDK and switch to the git branch with changes.
  2. Go to <some_project> > Settings > Merge requests.
  3. Look up the Merge request approvals section.
  4. Add/Remove/Update approval rules and review the results.
  5. Add 20+ rules. Click Show more button and review the result.

Merge request reports