Record time in suggestions api
What does this MR do and why?
issue: #441649 (closed)
Related to &12224 (comment 1770963792)
Currently there is no metric to measure time spent by code completions request between Rails and AI gateway (latency added by sending request from Rails to AI gateway). We could use same approach as with rails queue duration: add timestamp to request headers and then calculate difference on AI gateway side similar to https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/middleware/rails_queue_duration.rb#L16
This assumes that time is accurate both on Rails and AI gateway server (in case of self-managed servers this may not be true).
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Related to #441649 (closed)
Merge request reports
Activity
changed milestone to %16.11
assigned to @tgao3701908
mentioned in issue #441649 (closed)
- A deleted user
added backend label
8 Warnings ⚠ This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.⚠ 9b167734: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ 19713832: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ e32c1dfd: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ e2572760: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. ⚠ e7fbc077: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. ⚠ This merge request has more than 20 commits which may cause issues in some of the jobs. If you see errors like missing commits, please consider squashing some commits so it is within 20 commits. ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Category Reviewer Maintainer backend @panoskanell
(UTC+3)
@jnutt
(UTC+1)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Dangeradded 2420 commits
-
e70381ae...ea5221a6 - 2419 commits from branch
master
- 9b167734 - Fix conflict with master
-
e70381ae...ea5221a6 - 2419 commits from branch
requested review from @reprazent and @jprovaznik
added 1599 commits
-
2fa351f6...2ad719d7 - 1597 commits from branch
master
- ad706cea - Merge branch 'master' into 441649-Measure_AI_gateway_queue_duration
- 86030c52 - Seconds instead of milliseconds
-
2fa351f6...2ad719d7 - 1597 commits from branch
- Resolved by Bob Van Landuyt
- Resolved by Jan Provaznik
Thanks @tgao3701908, I left a minor question inline, but overall it looks good!
removed review request for @jprovaznik