Skip to content

Adjust Branch Rules Settings UI to new designs

Paulina Sedlak-Jakubowska requested to merge 388129-ui-update into master

What does this MR do and why?

Adjust UI to new designs

  • changing card title
  • changing cards to new card color scheme
  • improving loading state
  • removing duplicate strings
  • removing redundand methods
  • adding missing alt text for avatars
  • correcting headings hierarchy

See comments in the code for more details

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Rule_details_loading_state_before Rule_details_loading_state_after
Top_page_before Top_page_after
Bottom_page_before Bottom_page_after

Note: This will temporarily show only No data to display for empty rules. This will be handled in !148412 (merged).

Screenshot_2024-04-11_at_15.47.53

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Open Rails console. In your terminal: rails c
  2. Enable the feature flag:
Feature.enable(:edit_branch_rules)
  1. In a project, go to Settings / Repository
  2. Expand Branch rules section
  3. Click on View details of a chosen rule or use Add branch rule button if you don't have any yet.

Related to #388129 (closed)

Edited by Paulina Sedlak-Jakubowska

Merge request reports