Skip to content

Remove usages of `sub-header-block`

Andrew Smith requested to merge espadav8/gitlab:454473-audit-and-remove-uses-of-sub-header-block into master

What does this MR do and why?

Remove usages of sub-header-block

The class is only used in one place, and it is used to create a 1px border between charts. This is easily replaced with the gl-border-t class.

✅ Blocked by: Remove sub-header background from Compare revis... (!148614 - merged) ✅

The previous MR removes a single usage of this class, and then this is a "follow up" MR to remove the remaining usages. TBH, both MRs could be merged into a single one, but splitting them out lets us discuss them independently.

I have been unable to test this MR locally because I do not currently have an EE licence.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
image image
light-mode-before.png light-mode-after.png

How to set up and validate locally

  1. Visit the graphs/master/charts for a project before and after the MR is applied and check the border is still present and correct

Related to #454473

Edited by Ragnar Hardarson

Merge request reports