Remove usages of `sub-header-block`
What does this MR do and why?
Remove usages of sub-header-block
The class is only used in one place, and it is used to create a 1px border between charts. This is easily replaced with the gl-border-t
class.
Blocked by: Remove sub-header background from Compare revis... (!148614 - merged)
The previous MR removes a single usage of this class, and then this is a "follow up" MR to remove the remaining usages. TBH, both MRs could be merged into a single one, but splitting them out lets us discuss them independently.
I have been unable to test this MR locally because I do not currently have an EE licence.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Visit the
graphs/master/charts
for a project before and after the MR is applied and check the border is still present and correct
Related to #454473 (closed)
Merge request reports
Activity
added frontend label
assigned to @espadav8
added Leading Organization label
Hey @espadav8!
Thank you for your contribution to GitLab. Please refer to the contribution documentation for an overview of the process.
Did you know about our community forks? Working from there will make your contribution process easier. Please check it out!
When you're ready for a first review, post
@gitlab-bot ready
. If you know a relevant reviewer(s) (for example, someone that was involved in a related issue), you can also assign them directly with@gitlab-bot ready @user1 @user2
.At any time, if you need help, feel free to post
@gitlab-bot help
or initiate a mentor session on Discord. Read more on how to get help.You can comment
@gitlab-bot label <label1> <label2>
to add labels to your MR. Please see the list of allowed labels in thelabel
command documentation.This message was generated automatically. You're welcome to improve it.
added Community contribution workflowin dev labels
added linked-issue label
- A deleted user
added backend label
Reviewer roulette
Category Reviewer Maintainer backend @bhrai
(UTC+2)
@pshutsin
(UTC+2)
frontend @andrei.zubov
(UTC+2)
@psjakubowska
(UTC+2)
UX @lvanc
(UTC-10)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @rhardarson
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits bd413fd5 and 1b327f54
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.32 MB 4.32 MB - 0.0 % mainChunk 3.31 MB 3.31 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded UX label
Thanks for helping us improve the UX of GitLab. Your contribution is appreciated! We have pinged our UX team, so stay tuned for their feedback.
This message was generated automatically. You're welcome to improve it.
- Resolved by Libor Vanc
@lvanc Do you see this change affecting any areas of the graphs/charts?
requested review from @lvanc
mentioned in issue gitlab-org/quality/triage-reports#17094 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17178 (closed)
added groupoptimize label
added devopsplan sectiondev labels
added maintenancerefactor label
added typemaintenance label
added 331 commits
-
5291c54e...fc9770b3 - 330 commits from branch
gitlab-org:master
- 1b327f54 - Remove usages of `sub-header-block`
-
5291c54e...fc9770b3 - 330 commits from branch
removed Leading Organization label
@gitlab-bot ready
added workflowready for review label and removed workflowin dev label
@rhardarson
@lvanc
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? If not, find one or more reviewers and assign to them.
- If you've reviewed it, add the workflowin dev label if these changes need more work before the next review.
This message was generated automatically. You're welcome to improve it.
mentioned in merge request !148614 (merged)
changed milestone to %16.11
added pipeline:mr-approved label
- Resolved by Jacques Erasmus
@lvanc
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, please start a new pipeline before merging.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
removed review request for @lvanc
- Resolved by Jacques Erasmus
@espadav8 I'm planning on taking a look at this today/tomorrow depending on my workload
If you want a quicker review I can find another engineer.
changed milestone to %17.0
requested review from @jerasmus and removed review request for @rhardarson
enabled an automatic merge when the pipeline for 71c961ab succeeds
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1b327f54expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 87 | 0 | 9 | 0 | 96 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 308 | 0 | 19 | 0 | 327 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 1b327f54expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 285 | 0 | 23 | 0 | 308 | ✅ | | Create | 182 | 0 | 21 | 2 | 203 | ✅ | | Govern | 28 | 0 | 0 | 0 | 28 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Verify | 18 | 0 | 0 | 0 | 18 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 551 | 0 | 52 | 2 | 603 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
@jerasmus, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
@espadav8, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- React with a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Subscribe to the GitLab Community Newsletter for contributor-focused content and opportunities to level up.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- React with a
mentioned in commit 9e413f08
added workflowstaging-canary label and removed workflowready for review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
added Leading Organization label
mentioned in issue #454473 (closed)
mentioned in merge request kubitus-project/kubitus-installer!3058 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label