Skip to content

Correctly parse the `canEdit` permission for project dropdown items

Andrew Smith requested to merge espadav8/gitlab:454472-clicking-on-project-settings-leads-to-404-page into master

What does this MR do and why?

Correctly parse the canEdit permission for project dropdown items

In the port of the page from HAML to Vue there was a missed parseBoolean from the canEdit data attribute used by the MoreActionsDropdown Vue app, this causes any text value for canEdit to be handled as a true value and thus causes the Project Settings link to always appear.

Changelog: fixed Signed-off-by: Andrew Smith espadav8@gmail.com

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

This is viewing the flightjs/flight project as a user who does not belong to the project or group.

Before After
image image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Related to #454472 (closed)

Edited by Andrew Smith

Merge request reports