MR widget: Fix alignment of approval button and text
What does this MR do and why?
MR widget: Fix alignment of approval button and text:
- Fixes text alignment to use same baseline alignment between button and text
- Aligns approval button to top on mobile
- Moves text below button on mobile
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
![]() |
![]() |
How to set up and validate locally
- Go to an MR and check the MR approval widget, e.g. http://gdk.test:3000/flightjs/Flight/-/merge_requests/8
Related to #425467 (closed)
Merge request reports
Activity
changed milestone to %16.11
assigned to @seggenberger
added devopscreate label
- Resolved by Denys Mishunov
requested review from @afracazo
2 Warnings ⚠ This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.1 Message 📖 This merge request includes changes to Vue files that have both CE and EE versions. Vue
<template>
in CE and EESome Vue files in CE have a counterpart in EE. (For example,
path/to/file.vue
andee/path/to/file.vue
.)When run in the context of CE, the
<template>
of the CE Vue file is used. When run in the context of EE, the<template>
of the EE Vue file is used.It's easy to accidentally make a change to a CE
<template>
that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:
app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals.vue
If you made a change to the
<template>
of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.A better alternative
An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag
testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/vue_merge_request_widget/components/approvals/approvals_summary.vue
- <div data-testid="approvals-summary-content"> + data-testid="approvals-summary-content"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @dzubova
(UTC+2, same timezone as author)
@fguibert
(UTC+10, 8 hours ahead of author)
UX @pedroms
(UTC+1, 1 hour behind author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 Danger- Resolved by Denys Mishunov
requested review from @dzubova
removed review request for @afracazo
added pipeline:mr-approved label
- Resolved by Denys Mishunov
👋 @afracazo
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b1b109d8 and 07cbdc49
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.26 MB 4.26 MB - 0.0 % mainChunk 3.23 MB 3.23 MB - 0.0 %
Note: We do not have exact data for b1b109d8. So we have used data from: d1f9b002.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerE2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
✅ test report for 07cbdc49expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Create | 77 | 0 | 9 | 0 | 86 | ✅ | | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 0 | 19 | 0 | 317 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
✅ test report for 07cbdc49expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Create | 570 | 0 | 66 | 10 | 636 | ✅ | | Govern | 6 | 0 | 0 | 0 | 6 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 596 | 0 | 68 | 10 | 664 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
requested review from @dmishunov and removed review request for @dzubova
enabled an automatic merge when the pipeline for b0bb326e succeeds
mentioned in commit e7dc2f4b
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2945 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label