Skip to content

Danger: Rename constants to avoid Ruby warnings

Peter Leitzen requested to merge pl-danger-constant-warning into master

What does this MR do and why?

Danger: Rename constants to avoid Ruby warnings

This commit resolves the following warnings:

gitlab/danger/saas_feature/Dangerfile:3: warning: already initialized constant Danger::Dangerfile::SEE_DOC
gitlab/danger/feature_flag/Dangerfile:3: warning: previous definition of SEE_DOC was here

Ideally, the code should go into danger plugins to side-step any namespace issues.

Contributes to #454412

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

How to verify in CI

Before After
⚠ https://gitlab.com/gitlab-org/gitlab/-/jobs/6543157263 ✅ https://gitlab.com/gitlab-org/gitlab/-/jobs/6545020422
Edited by Peter Leitzen

Merge request reports