Skip to content

Pass alert bot user when creating incidents

Peter Leitzen requested to merge pl-incident-issue-service-alert_bot into master

What does this MR do?

Previously, we passed nil as current_user to IncidentManagement::CreateIssueService.new and used issue_author.

After this commit we pass User.alert_bot explicitly and utilize current_user in the service as usual.

Does this MR meet the acceptance criteria?

Conformity

Performance and testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Leitzen

Merge request reports