Skip to content

Remove FF search_add_archived_filter_to_zoekt

Terri Chu requested to merge 451096-remove-ff-attempt-2 into master

What does this MR do and why?

Related #454338 (closed) and #451096 (closed)

The feature flag was removed in !148107 (merged) and that MR was reverted in !148542 (merged)

This MR re-instates the original removal MR and includes a fix for project zoekt searches to always send down include_archived and include_forked flags otherwise no results are shown.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

group search default (no archived)

image

group search include archived

image

project search (archived)

image

How to set up and validate locally

  1. enable and configure zoekt for a namespace
  2. make sure the namespace has at least one archived project with searchable text. Since i created new projects with the default README, I searched for "To make it easy for you to get started with GitLab"
  3. do a group code search (ensure that Zoekt code search is enabled in your user preferences)
  4. verify the include archived checkbox shows up and by default is unchecked
  5. verify archived results not returned
  6. select include archived and re-run the search
  7. verify archived results are returned

Fix for project search

  1. do a project code search for the archived project
  2. verify archived results are returned
Edited by Terri Chu

Merge request reports