Move epic type filter behind feature flag

added frontend groupproject management typebug labels

added Category:Team Planning devopsplan sectiondev labels

marked this merge request as ready

added backend label

	1 Message
	This merge request includes changes to Vue files that have both CE and EE versions.

Vue `<template>` in CE and EE

Some Vue files in CE have a counterpart in EE. (For example, path/to/file.vue and ee/path/to/file.vue.)

When run in the context of CE, the <template> of the CE Vue file is used. When run in the context of EE, the <template> of the EE Vue file is used.

It's easy to accidentally make a change to a CE <template> that should appear in both CE and EE without making the change in both places. When this happens, the change only takes effect in CE.

The following Vue files were changed as part of this merge request that include both a CE and EE version of the file:

ee/app/assets/javascripts/issues/list/components/issues_list_app.vue

If you made a change to the <template> of any of these Vue files that should be visible in both CE and EE, please ensure you have made your change to both versions of the file.

A better alternative

An even better alternative is to refactor this component to only use a single template for both CE and EE. More info on this approach here: https://docs.gitlab.com/ee/development/ee_features.html#template-tag

Reviewer roulette

Category	Reviewer	Maintainer
frontend	`@jmontal` (UTC-6, 1 hour behind author)	`@aturinske` (UTC-7, 2 hours behind author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

839fa7be - Move epic type filter to FF

Compare with previous version

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits bf2f79f1 and c9f8d396

Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.25 MB	4.25 MB	-	0.0 %
mainChunk	3.23 MB	3.23 MB	-	0.0 %

Note: We do not have exact data for bf2f79f1. So we have used data from: d5894e87.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.

Please look at the full report for more details

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for c9f8d396

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 66     | 0      | 0       | 0     | 66    | ✅     |
| Create      | 77     | 0      | 9       | 0     | 86    | ✅     |
| Plan        | 51     | 0      | 2       | 0     | 53    | ✅     |
| Monitor     | 7      | 0      | 0       | 0     | 7     | ✅     |
| Release     | 5      | 0      | 0       | 0     | 5     | ✅     |
| Verify      | 35     | 0      | 1       | 0     | 36    | ✅     |
| Data Stores | 31     | 0      | 0       | 0     | 31    | ✅     |
| Package     | 24     | 0      | 6       | 0     | 30    | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 298    | 0      | 19      | 0     | 317   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for c9f8d396

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Plan        | 249    | 0      | 19      | 0     | 268   | ✅     |
| Create      | 152    | 0      | 21      | 2     | 173   | ✅     |
| Package     | 0      | 0      | 2       | 0     | 2     | ➖     |
| Data Stores | 4      | 0      | 0       | 0     | 4     | ✅     |
| Monitor     | 8      | 0      | 0       | 0     | 8     | ✅     |
| Govern      | 6      | 0      | 0       | 0     | 6     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 419    | 0      | 42      | 2     | 461   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+