Disable allow_failure for release-environments pipeline
What does this MR do and why?
We want to the QA downstream pipeline to fail the parent pipeline of release-environment if QA job fails.
part of: gitlab-com/gl-infra/delivery#19969 (closed)
Tackles: gitlab-com/gl-infra/delivery#20118 (closed)
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
Merge request reports
Activity
added typemaintenance label
requested review from @dat.tang.gitlab and @mayra-cabrera
assigned to @ahyield
1 Warning This merge request does not refer to an existing milestone. Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Category Reviewer Maintainer ~"Pipeline configuration" Reviewer review is optional for ~"Pipeline configuration" @ddieulivol
(UTC+2, same timezone as author)
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangerrequested review from @nao.hashizume
- Resolved by Nao Hashizume
@nao.hashizume can you please review this tiny MR.
- Resolved by Jenny Kim
We might want to wait for this MR until: gitlab-com/gl-infra/delivery#20095 (closed)
added maintenancepipelines label
removed review request for @nao.hashizume
added pipeline:mr-approved label
- Resolved by Nao Hashizume
@nao.hashizume
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for d696707eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Package | 16 | 0 | 15 | 0 | 31 | ✅ | | Verify | 44 | 0 | 2 | 0 | 46 | ✅ | | Govern | 71 | 0 | 0 | 0 | 71 | ✅ | | Create | 127 | 0 | 12 | 0 | 139 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 70 | 0 | 0 | 0 | 70 | ✅ | | Manage | 1 | 0 | 1 | 0 | 2 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Data Stores | 31 | 0 | 1 | 0 | 32 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Secure | 2 | 0 | 0 | 0 | 2 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 379 | 0 | 31 | 0 | 410 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-test-on-cng:
test report for 174f619aexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 83 | 0 | 6 | 0 | 89 | ✅ | | Create | 139 | 0 | 15 | 0 | 154 | ✅ | | Govern | 79 | 0 | 9 | 0 | 88 | ✅ | | Fulfillment | 2 | 0 | 24 | 0 | 26 | ✅ | | Manage | 2 | 0 | 8 | 0 | 10 | ✅ | | Verify | 55 | 0 | 11 | 0 | 66 | ✅ | | Ai-powered | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 34 | 0 | 9 | 0 | 43 | ✅ | | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | | Package | 23 | 0 | 15 | 0 | 38 | ✅ | | Release | 5 | 0 | 1 | 0 | 6 | ✅ | | Configure | 0 | 0 | 3 | 0 | 3 | ➖ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | | ModelOps | 0 | 0 | 1 | 0 | 1 | ➖ | | Secure | 3 | 0 | 1 | 0 | 4 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 435 | 0 | 118 | 0 | 553 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
- Resolved by Jenny Kim
@jennykim-gitlab Bringing this merge request to your attention. It removes the
allow_failure
from the release environment pipeline, which will effectively block pipelines when release environments fail. It was blocked due to lack of documentation and runbooks, but now that we have those I'm still unsure if we should merge it, or wait until a specific step.
added pipelinetier-2 label
added 13490 commits
-
c382d3c8...00235143 - 13489 commits from branch
master
- 174f619a - Disable allow_failure for release-environments pipeline
-
c382d3c8...00235143 - 13489 commits from branch
added pipelinetier-3 label and removed pipelinetier-2 label
- Resolved by Mayra Cabrera
Before you set this MR to auto-merge
This merge request will progress on pipeline tiers until it reaches the last tier: pipelinetier-3. We will trigger a new pipeline for each transition to a higher tier.
Before you resolve this discussion, please check the following:
- You are the last maintainer of this merge request
- The latest pipeline for this merge request is pipelinetier-3 (You can find which tier it is in the pipeline name)
- This pipeline is recent enough (created in the last 8 hours)
If all the criteria above apply, please resolve this discussion and the set auto-merge for this merge request.
See pipeline tiers and merging a merge request for more details.
Security policy violations have been resolved.
Edited by GitLab Security Botadded 9939 commits
-
174f619a...f102a149 - 9937 commits from branch
master
- 78e75090 - Disable allow_failure for release-environments pipeline
- 3a1a231e - Disable allow_failure for the security downstream pipeline
-
174f619a...f102a149 - 9937 commits from branch
reset approvals from @nao.hashizume by pushing to the branch
added 13 commits
-
3a1a231e...d9e47489 - 12 commits from branch
master
- d696707e - Disable allow_failure for the security downstream pipeline
-
3a1a231e...d9e47489 - 12 commits from branch
requested review from @nao.hashizume
- Resolved by Mayra Cabrera
@nao.hashizume @mayra-cabrera @dat.tang.gitlab I believe this MR is good to go ahead with the review + merge since we're a lot more confident in our RE downstream pipeline as validation step for our releases.
started a merge train
removed this merge request from the merge train because the pipeline did not succeed. Learn more.
assigned to @jennykim-gitlab and unassigned @ahyield
started a merge train
mentioned in commit 7b5b756c
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
changed milestone to %17.4
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label