Make #wlif_issuer_url work for group or project

changed the description

	2 Warnings
	2bfc2d6a: The commit body should not contain more than 72 characters per line. For more information, take a look at our Commit message guidelines.
	This merge request does not refer to an existing milestone.

	2 Messages
	This merge request adds or changes files that require a review from the CI/CD Templates maintainers.
	This merge request adds or changes files that require a review from the Database team.

This merge request requires a CI/CD Template review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has the citemplates label. If the merge request modifies CI/CD Template files, Danger will do this for you.
Prepare your MR for a CI/CD Template review according to the template development guide.
Assign and @ mention the CI/CD Template reviewer suggested by Reviewer Roulette.

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
Prepare your MR for database review according to the docs.
Assign and mention the database reviewer suggested by Reviewer Roulette.

If you no longer require a database review, you can remove this suggestion by removing the database label and re-running the danger-review job.

Reviewer roulette

Category	Reviewer	Maintainer
analytics instrumentation	`@nbelokolodov` (UTC+13, 11 hours ahead of author)	Maintainer review is optional for analytics instrumentation
backend	`@hmerscher` (UTC+2, same timezone as author)	`@maddievn` (UTC+7, 5 hours ahead of author)
database	`@nmilojevic1` (UTC+2, same timezone as author)	`@ghavenga` (UTC+2, same timezone as author)
groupimport and integrate (backend)	`@ivaneG` (UTC+1, 1 hour behind author)	Maintainer review is optional for groupimport and integrate (backend)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added groupauthentication + 1 deleted label

added devopsgovern sectionsec labels

Proper labels assigned to this merge request. Please ignore me.

@eduardosanz - please see the following guidance and update this merge request.

	1 Error
	Please add typebug typefeature, or typemaintenance label to this merge request.

removed devopsgovern sectionsec labels

added devopsgovern sectionsec labels

removed 1 deleted label

added featureenhancement typefeature labels

resolved all threads

@atevans, please could you review this MR? Thanks!

requested review from @atevans

lg2m!

approved this merge request

added pipeline:mr-approved label

@atevans, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break master, a new pipeline will be started shortly.

Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.

E2E Test Result Summary

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 23d3ac8c

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 144    | 2      | 15      | 0     | 161   | ❌     |
| Plan        | 97     | 1      | 4       | 0     | 102   | ❌     |
| Verify      | 69     | 1      | 2       | 0     | 72    | ❌     |
| Govern      | 129    | 0      | 0       | 0     | 129   | ✅     |
| Data Stores | 57     | 3      | 0       | 0     | 60    | ❌     |
| Release     | 10     | 0      | 0       | 0     | 10    | ✅     |
| Package     | 48     | 0      | 11      | 0     | 59    | ✅     |
| Manage      | 0      | 0      | 2       | 0     | 2     | ➖     |
| Monitor     | 10     | 0      | 0       | 0     | 10    | ✅     |
| Analytics   | 4      | 0      | 0       | 0     | 4     | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 568    | 7      | 34      | 0     | 609   | ❌     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 23d3ac8c

expand test summary

+---------------------------------------------------------------------+
|                           suites summary                            |
+----------------+--------+--------+---------+-------+-------+--------+
|                | passed | failed | skipped | flaky | total | result |
+----------------+--------+--------+---------+-------+-------+--------+
| Systems        | 10     | 0      | 0       | 0     | 10    | ✅     |
| Plan           | 328    | 0      | 25      | 0     | 353   | ✅     |
| Create         | 691    | 14     | 101     | 12    | 806   | ❌     |
| Manage         | 40     | 1      | 14      | 1     | 55    | ❌     |
| Govern         | 350    | 0      | 26      | 0     | 376   | ✅     |
| Verify         | 200    | 0      | 40      | 4     | 240   | ✅     |
| Analytics      | 9      | 0      | 0       | 0     | 9     | ✅     |
| Data Stores    | 153    | 0      | 37      | 0     | 190   | ✅     |
| Fulfillment    | 10     | 0      | 100     | 1     | 110   | ✅     |
| Package        | 234    | 1      | 46      | 18    | 281   | ❌     |
| GitLab Metrics | 2      | 0      | 1       | 0     | 3     | ✅     |
| Monitor        | 44     | 0      | 17      | 0     | 61    | ✅     |
| Release        | 20     | 0      | 4       | 0     | 24    | ✅     |
| Ai-powered     | 0      | 0      | 4       | 0     | 4     | ➖     |
| Configure      | 1      | 0      | 12      | 0     | 13    | ✅     |
| Secure         | 8      | 0      | 4       | 0     | 12    | ✅     |
| ModelOps       | 0      | 0      | 4       | 0     | 4     | ➖     |
| Growth         | 0      | 0      | 8       | 0     | 8     | ➖     |
+----------------+--------+--------+---------+-------+-------+--------+
| Total          | 2100   | 16     | 443     | 36    | 2559  | ❌     |
+----------------+--------+--------+---------+-------+-------+--------+

e2e-test-on-cng: test report for 23d3ac8c

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Create      | 143    | 0      | 23      | 2     | 166   | ✅     |
| Verify      | 50     | 0      | 10      | 0     | 60    | ✅     |
| Package     | 29     | 0      | 10      | 0     | 39    | ✅     |
| Plan        | 83     | 0      | 6       | 0     | 89    | ✅     |
| Govern      | 83     | 0      | 6       | 2     | 89    | ✅     |
| Data Stores | 36     | 0      | 9       | 0     | 45    | ✅     |
| Ai-powered  | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor     | 12     | 0      | 4       | 0     | 16    | ✅     |
| Fulfillment | 2      | 0      | 25      | 0     | 27    | ✅     |
| Release     | 5      | 0      | 1       | 0     | 6     | ✅     |
| Secure      | 2      | 0      | 1       | 0     | 3     | ✅     |
| Analytics   | 2      | 0      | 0       | 0     | 2     | ✅     |
| Manage      | 2      | 0      | 3       | 0     | 5     | ✅     |
| Growth      | 0      | 0      | 2       | 0     | 2     | ➖     |
| Configure   | 0      | 0      | 3       | 0     | 3     | ➖     |
| ModelOps    | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 449    | 0      | 105     | 4     | 554   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

added 1 commit

81482de6 - Apply suggestion from backend reviewer

Compare with previous version

@jarka, could you do the backend maintainer review? Thanks!

requested review from @jarka

@minahilnichols, please could you do the initial frontend review? Thanks!

requested review from @minahilnichols

removed review request for @atevans and @minahilnichols

requested review from @minahilnichols

added 499 commits

81482de6...8cb813b2 - 489 earlier commits
edaa9a58 - Remove outdated screenshot and details
a4ccd1f5 - Merge branch 'docs-mr-pipelines-old-screenshot' into 'master'
e747d45b - Update Google Cloud IAM manual setup instructions
e3929c48 - Apply suggestion from UX reviewer
8af336a2 - Added missing tests
40c0384d - Apply 2 suggestion from product designer
26bdcb8f - Remove GlSprint for a simple GlLink
8db2aae2 - Remove extension from the help path
95694833 - Make #wlif_issuer_url work for group or project
23d3ac8c - Improve frontend tests

Compare with previous version

reset approvals from @atevans by pushing to the branch

marked this merge request as draft

mentioned in issue Taucher2003/reporting#431 (closed)

removed pipeline:mr-approved label

added Architecture Evolution Blueprint QA analytics instrumentation analytics instrumentationreview pending citemplates database databasereview pending development guidelines docsimprovement documentation feature flag groupanti-abuse maintenancerefactor typemaintenance labels and removed groupauthentication typefeature labels

removed featureenhancement label

added Data WarehouseImpact Check label

added 1 commit

2924018e - Make #wlif_issuer_url work for group or project

Compare with previous version

@minahilnichols, I have decided to remove the frontend part, so I am unassigning you. Sorry for the noise.

removed review request for @minahilnichols

changed target branch from eduardosanz/gc-iam-improvements-4 to master

added 1 commit

2bfc2d6a - Make #wlif_issuer_url work for group or project

Compare with previous version

marked this merge request as ready

mentioned in incident gitlab-org/quality/engineering-productivity/review-apps-broken-incidents#1522 (closed)

marked this merge request as draft

Thanks @eduardosanz, backend looks good to me! It is marked as a draft, so I am not merging. Let me know when this can be merged/is in final state.

removed review request for @jarka

approved this merge request

added pipeline:mr-approved label

approved this merge request

marked this merge request as ready

resolved all threads

merged

@eduardosanz, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 4 hours ago, you should:

Ensure the merge request is not in Draft status.
Start a pipeline (especially important for Community contribution merge requests).
Set the merge request to auto-merge.

This is a guideline, not a rule. Please consider replying to this comment for transparency.

This message was generated automatically. You're welcome to improve it.