Skip to content

Hide branch selector and branch column when editing branch rules

What does this MR do and why?

Hides the branch selector and branch column on the approvals app when viewing/adding/editing approval rules on the branch rules page

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2024-04-08_at_14.20.59 Screenshot_2024-04-08_at_14.20.03
Screenshot_2024-04-08_at_14.21.09 Screenshot_2024-04-08_at_14.20.13

How to set up and validate locally

  1. Enable the approval_rules_drawer
  2. Add a Branch rule via Project > Settings > Repository > Branch rules
  3. View the Branch rules details
  4. On the Branch rules details page scroll down to Approvals section
  5. The Target branch should nit be rendered in the approvals table
  6. Adding/Editing an approval rule should not display the target branch

Related to #439367 (closed)

Edited by Jacques Erasmus

Merge request reports