Skip to content

Don't restrict number of promotion candidates in json file

Sanad Liaquat requested to merge shl-dont-restrict-no-of-promotions into master

What does this MR do and why?

The code in gitlab_quality-test_tooling project that uses the json output may skip some specs and this will result in lesser number of specs being promoted per report. We would like to keep it at least at 10 for now. So we moved the code for selecting 10 specs to the gitlab_quality-test_tooling project and here, we will write all the candidates to file.

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Change the PROJECT_ID to an id of a project on your local.

From the qa/ directory, run:

GITLAB_ACCESS_TOKEN=<YOUR_PAT> CI_API_V4_URL=http://gdk.test:3000/api/v4/ QA_INFLUXDB_URL=https://influxdb.quality.gitlab.net QA_INFLUXDB_TOKEN=<QA_INFLUXDB_TOKEN_FROM_1P> bundle exec rake "reliable_spec_report[14, true]"

Notice the file qa/tmp/stable_specs.json has more than 10 specs.

Edited by Sanad Liaquat

Merge request reports