Add fullPath to CatalogResource graphl query
What does this MR do and why?
This MR adds the fullPath
in the GQL query to fix the bug found in #450914 (closed)
The fullPath
is then used in Catalog resource list item to replace the resourceId with fullPath instead of webPath
.
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
NA
How to set up and validate locally
- Setup local gdk on a relative URL following this guide.
- Check for
/explore/catalog
for components. If you do have any catalog resources, you can create some by following step via rails console.
Seed the db with catalog resources using bundle exec rake "gitlab:seed:ci_catalog_resources[Flightjs, 12, true]". This adds 12 components.
- Then head to
/explore/catalog
. - The link for Resource name should work as expected and redirect to details page.
Related to #450914 (closed)
Merge request reports
Activity
changed milestone to %17.0
assigned to @rkadam3
mentioned in issue #450914 (closed)
2 Warnings There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
The master pipeline status page reported failures in If these jobs fail in your merge request with the same errors, then they are not caused by your changes.
Please check for any on-going incidents in the incident issue tracker or in the#master-broken
Slack channel.Reviewer roulette
Category Reviewer Maintainer frontend @bsandlin
(UTC-5, 10.5 hours behind author)
@ankit.panchal
(UTC+5.5, same timezone as author)
UX No reviewer available Maintainer review is optional for UX ~"Verify" Reviewer review is optional for ~"Verify" @jivanvl
(UTC-6, 11.5 hours behind author)
Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits e91bbee8 and bbdb451e
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.3 MB 4.3 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in epic &7462
- Resolved by Robert Hunt
requested review from @rcrespo3
@rkadam3 sounds good! I will review this today or tomorrow, I'll assign myself :)
requested review from @lauraXD
- Resolved by Rajendra Kadam
- Resolved by Rajendra Kadam