Skip to content
Snippets Groups Projects

Update description field component

All threads resolved!

What does this MR do and why?

As part of the FE: Create design management work items widget (&12490 - closed), this MR will

  • When empty, just show an "Add a description" button (no heading)
  • When filled, show the heading with an Edit (icon only) button in line
  • Include a line break (horizontal rule) between the description area and the threads/discussion area

MR acceptance checklist

Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Screenshots or screen recordings

Screen Recording 2024-04-02 at 5.41.11 PM.mov

How to set up and validate locally

Steps to verify:

  1. Login with any user
  2. Go to any Group > Projects > Issues
  3. Create a new Issue
  4. Go to Issue detail page and upload a design/image
  5. Click on the design to preview
  6. Interact with description feature by
    1. adding new description
    2. edit the description
    3. remove the description to check if the Add a description is retained

Related to #438907 (closed)

Edited by Rajan Mistry

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rajan Mistry added 222 commits

    added 222 commits

    Compare with previous version

  • Rajan Mistry added 680 commits

    added 680 commits

    Compare with previous version

  • requested review from @lorenzvanherwaarden

  • Rajan Mistry added 1 commit

    added 1 commit

    • 1b84a03b - Add more test cases for description form and button

    Compare with previous version

  • requested review from @lorenzvanherwaarden

  • requested review from @fguibert

  • Lorenz van Herwaarden approved this merge request

    approved this merge request

  • removed review request for @lorenzvanherwaarden

  • Florie Guibert
  • Rajan Mistry added 214 commits

    added 214 commits

    • 1b84a03b...22546706 - 210 commits from branch master
    • 4ced0f41 - Update description field component
    • 7297000e - Code changes from the review
    • d968a491 - Add more test cases for description form and button
    • 811a1554 - Move add button to description form to simplify

    Compare with previous version

  • Rajan Mistry added 1 commit

    added 1 commit

    • 587f9e4c - Move add button to description form to simplify

    Compare with previous version

  • Rajan Mistry added 1 commit

    added 1 commit

    • b2c30ed5 - Move add button to description form to simplify

    Compare with previous version

  • Rajan Mistry added 422 commits

    added 422 commits

    • b2c30ed5...fe99bb18 - 417 commits from branch master
    • 29cc481e - Update description field component
    • c0414cd0 - Code changes from the review
    • 1924d1ce - Add more test cases for description form and button
    • bad9f116 - Move add button to description form to simplify
    • 8b0ac4a7 - Hide description form itself instead of showing none

    Compare with previous version

  • Rajan Mistry reset approvals from @lorenzvanherwaarden by pushing to the branch

    reset approvals from @lorenzvanherwaarden by pushing to the branch

  • Florie Guibert resolved all threads

    resolved all threads

  • Florie Guibert approved this merge request

    approved this merge request

  • Florie Guibert enabled an automatic merge when the pipeline for 6e4b4d02 succeeds

    enabled an automatic merge when the pipeline for 6e4b4d02 succeeds

  • mentioned in commit 6f8aae97

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading