Update description field component
What does this MR do and why?
As part of the FE: Create design management work items widget (&12490 - closed), this MR will
- When empty, just show an "Add a description" button (no heading)
- When filled, show the heading with an Edit (icon only) button in line
- Include a line break (horizontal rule) between the description area and the threads/discussion area
MR acceptance checklist
Please evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Screenshots or screen recordings
Screen Recording 2024-04-02 at 5.41.11 PM.mov
How to set up and validate locally
Steps to verify:
- Login with any user
- Go to any Group > Projects > Issues
- Create a new
Issue
- Go to Issue detail page and upload a design/image
- Click on the design to preview
- Interact with description feature by
- adding new description
- edit the description
- remove the description to check if the
Add a description
is retained
Related to #438907 (closed)
Merge request reports
Activity
changed milestone to %17.0
assigned to @ramistry
3 Warnings 8b0ac4a7: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. bad9f116: Commits that change 30 or more lines across at least 3 files should describe these changes in the commit body. For more information, take a look at our Commit message guidelines. This merge request contains lines with testid selectors. Please ensure e2e:package-and-test
job is run.testid
selectorsThe following changed lines in this MR contain
testid
selectors:app/assets/javascripts/design_management/components/design_description/description_form.vue
- data-testid="edit-description" - data-testid="design-description-none" + data-testid="add-design-description" - data-testid="design-description-content" + data-testid="edit-description" + data-testid="design-description-content"
app/assets/javascripts/design_management/components/design_sidebar.vue
- <h3 data-testid="unresolved-discussion-count" class="gl-line-height-20! gl-font-lg"> + data-testid="unresolved-discussion-count"
If the
e2e:package-and-test
job in theqa
stage has run automatically, please ensure the tests are passing. If the job has not run, please start themanual:e2e-test-pipeline-generate
job in theprepare
stage and ensure the tests infollow-up:e2e:package-and-test-ee
pipeline are passing.For the list of known failures please refer to the latest pipeline triage issue.
If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.
Reviewer roulette
Category Reviewer Maintainer frontend @minahilnichols
(UTC-4, 9.5 hours behind author)
@zcuddy
(UTC-5, 10.5 hours behind author)
UX @nickbrandt
(UTC-6, 11.5 hours behind author)
Maintainer review is optional for UX Please check reviewer's status!
Please refer to documentation page for guidance on how you can benefit from the Reviewer Roulette, or use the GitLab Review Workload Dashboard to find other available reviewers.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits bf1f588a and 8b0ac4a7
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.3 MB 4.3 MB - 0.0 % mainChunk 3.3 MB 3.3 MB - 0.0 %
Note: We do not have exact data for bf1f588a. So we have used data from: 9b1de328.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Danger- Resolved by Nick Brandt
Hey @nickbrandt, can you please review the UX till I cover the test case?
requested review from @nickbrandt
added 641 commits
-
72f36a71...768ffab4 - 640 commits from branch
master
- 3d549cf3 - Update description field component
-
72f36a71...768ffab4 - 640 commits from branch
added pipeline:mr-approved label
- Resolved by Florie Guibert
@nickbrandt
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure we don't only run predictive pipelines, and we don't break
master
, a new pipeline will be started shortly.Please wait for the pipeline to start before resolving this discussion and set auto-merge for the new pipeline. See merging a merge request for more details.
E2E Test Result Summary
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 8b0ac4a7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 31 | 0 | 0 | 0 | 31 | ✅ | | Create | 87 | 0 | 9 | 0 | 96 | ✅ | | Plan | 51 | 0 | 2 | 0 | 53 | ✅ | | Verify | 35 | 0 | 1 | 0 | 36 | ✅ | | Govern | 66 | 0 | 0 | 0 | 66 | ✅ | | Monitor | 7 | 0 | 0 | 0 | 7 | ✅ | | Package | 24 | 0 | 6 | 0 | 30 | ✅ | | Release | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 308 | 0 | 19 | 0 | 327 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 8b0ac4a7expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 285 | 0 | 23 | 0 | 308 | ✅ | | Create | 182 | 0 | 21 | 2 | 203 | ✅ | | Verify | 18 | 0 | 0 | 0 | 18 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Govern | 28 | 0 | 0 | 0 | 28 | ✅ | | Release | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 6 | 0 | 8 | 0 | 14 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 551 | 0 | 52 | 2 | 603 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
added 272 commits
-
3d549cf3...2c828991 - 271 commits from branch
master
- 89ce6e41 - Update description field component
-
3d549cf3...2c828991 - 271 commits from branch
mentioned in incident gitlab-org/quality/engineering-productivity/review-apps-broken-incidents#1568 (closed)
- Resolved by Florie Guibert
Hey @lorenzvanherwaarden, can you please review the frontend and pass it to
@fguibert
for the maintainer-ship?
requested review from @lorenzvanherwaarden
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
added 222 commits
-
89ce6e41...fa08c704 - 220 commits from branch
master
- 7aba606f - Update description field component
- c2de527a - Code changes from the review
-
89ce6e41...fa08c704 - 220 commits from branch
mentioned in incident gitlab-org/quality/engineering-productivity/review-apps-broken-incidents#1585 (closed)
added 680 commits
-
c2de527a...6dd81499 - 677 commits from branch
master
- 0dc19420 - Update description field component
- bf7aa2b3 - Code changes from the review
- e2d17e44 - Add more test cases for description form and button
Toggle commit list-
c2de527a...6dd81499 - 677 commits from branch
requested review from @lorenzvanherwaarden
- Resolved by Lorenz van Herwaarden
- Resolved by Lorenz van Herwaarden
added 1 commit
- 1b84a03b - Add more test cases for description form and button
requested review from @lorenzvanherwaarden
requested review from @fguibert
removed review request for @lorenzvanherwaarden
- Resolved by Florie Guibert
added 214 commits
-
1b84a03b...22546706 - 210 commits from branch
master
- 4ced0f41 - Update description field component
- 7297000e - Code changes from the review
- d968a491 - Add more test cases for description form and button
- 811a1554 - Move add button to description form to simplify
Toggle commit list-
1b84a03b...22546706 - 210 commits from branch
added 1 commit
- 587f9e4c - Move add button to description form to simplify
added 1 commit
- b2c30ed5 - Move add button to description form to simplify
added 422 commits
-
b2c30ed5...fe99bb18 - 417 commits from branch
master
- 29cc481e - Update description field component
- c0414cd0 - Code changes from the review
- 1924d1ce - Add more test cases for description form and button
- bad9f116 - Move add button to description form to simplify
- 8b0ac4a7 - Hide description form itself instead of showing none
Toggle commit list-
b2c30ed5...fe99bb18 - 417 commits from branch
reset approvals from @lorenzvanherwaarden by pushing to the branch
enabled an automatic merge when the pipeline for 6e4b4d02 succeeds
mentioned in commit 6f8aae97
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!3058 (merged)
added releasedpublished label and removed releasedcandidate label
added pipelinetier-3 label