Skip to content
Snippets Groups Projects

Simplify commit and snippet notes

Merged Annabel Dunstone Gray requested to merge simplify-commit-snippet-wiki-notes into master

What does this MR do and why?

  • Fixes vertical line
  • Removes extra system note for threads (and collapse functionality)
    • Why? We don't actually show the Reply option here anyway; you can only get to this state if you select Start a thread instead of Comment. And the collapsed state isn't persisted.
  • Fix mobile styles
  • On mobile, hides Edit icon button and adds Edit comment option in actions dropdown

What does this MR not do?

  • Convert the notes to Vue

Screenshots or screen recordings

Before After
Screenshot_2024-03-28_at_2.13.18_PM Screenshot_2024-03-28_at_2.09.30_PM
Screenshot_2024-03-28_at_4.22.45_PM Screenshot_2024-03-28_at_4.29.09_PM

How to set up and validate locally

Check areas that use our legacy notes:

  • Snippet
  • Commit
  • Are there any others? I thought wiki used them too but I don't actually see a way to comment anywhere on wikis 🤔

Links

Edited by Annabel Dunstone Gray

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • requested review from @rcrespo3 and @sam.figueroa

  • Rudy Crespo
  • I have reviewed the merge request and left comments. I suggested using our gl-* classes and writing a test for the code. I estimate a small amount of work is required to address these comments.

  • added 232 commits

    Compare with previous version

  • added 1 commit

    • d6bf40a5 - Fix specs; remove potentially unneeded stuff

    Compare with previous version

  • requested review from @rcrespo3

  • requested review from @rcrespo3

  • added 46 commits

    Compare with previous version

  • Michael Le approved this merge request

    approved this merge request

  • Michael Le removed review request for @mle

    removed review request for @mle

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading